projects
/
yaffs2.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
yaffs Fixing some minor warnings in direct/timothy_tests/linux_tests
[yaffs2.git]
/
yaffs_ecc.c
diff --git
a/yaffs_ecc.c
b/yaffs_ecc.c
index 71ebe765c9d29bd40056d28097128045fd3f3503..e95a8069a8c5bc0c754b9f41ddbc9944e0b76f98 100644
(file)
--- a/
yaffs_ecc.c
+++ b/
yaffs_ecc.c
@@
-67,29
+67,6
@@
static const unsigned char column_parity_table[] = {
0x69, 0x3c, 0x30, 0x65, 0x0c, 0x59, 0x55, 0x00,
};
0x69, 0x3c, 0x30, 0x65, 0x0c, 0x59, 0x55, 0x00,
};
-/* Count the bits in an unsigned char or a U32 */
-
-static int yaffs_count_bits(unsigned char x)
-{
- int r = 0;
- while (x) {
- if (x & 1)
- r++;
- x >>= 1;
- }
- return r;
-}
-
-static int yaffs_count_bits32(unsigned x)
-{
- int r = 0;
- while (x) {
- if (x & 1)
- r++;
- x >>= 1;
- }
- return r;
-}
/* Calculate the ECC for a 256-byte block of data */
void yaffs_ecc_cacl(const unsigned char *data, unsigned char *ecc)
/* Calculate the ECC for a 256-byte block of data */
void yaffs_ecc_cacl(const unsigned char *data, unsigned char *ecc)
@@
-106,7
+83,7
@@
void yaffs_ecc_cacl(const unsigned char *data, unsigned char *ecc)
b = column_parity_table[*data++];
col_parity ^= b;
b = column_parity_table[*data++];
col_parity ^= b;
- if (b & 0x01) {
/* odd number of bits in the byte */
+ if (b & 0x01) { /* odd number of bits in the byte */
line_parity ^= i;
line_parity_prime ^= ~i;
}
line_parity ^= i;
line_parity_prime ^= ~i;
}
@@
-160,11
+137,10
@@
void yaffs_ecc_cacl(const unsigned char *data, unsigned char *ecc)
#endif
}
#endif
}
-
/* Correct the ECC on a 256 byte block of data */
int yaffs_ecc_correct(unsigned char *data, unsigned char *read_ecc,
/* Correct the ECC on a 256 byte block of data */
int yaffs_ecc_correct(unsigned char *data, unsigned char *read_ecc,
- const unsigned char *test_ecc)
+
const unsigned char *test_ecc)
{
unsigned char d0, d1, d2; /* deltas */
{
unsigned char d0, d1, d2; /* deltas */
@@
-173,7
+149,7
@@
int yaffs_ecc_correct(unsigned char *data, unsigned char *read_ecc,
d2 = read_ecc[2] ^ test_ecc[2];
if ((d0 | d1 | d2) == 0)
d2 = read_ecc[2] ^ test_ecc[2];
if ((d0 | d1 | d2) == 0)
- return 0; /* no error */
+ return 0;
/* no error */
if (((d0 ^ (d0 >> 1)) & 0x55) == 0x55 &&
((d1 ^ (d1 >> 1)) & 0x55) == 0x55 &&
if (((d0 ^ (d0 >> 1)) & 0x55) == 0x55 &&
((d1 ^ (d1 >> 1)) & 0x55) == 0x55 &&
@@
-220,19
+196,17
@@
int yaffs_ecc_correct(unsigned char *data, unsigned char *read_ecc,
data[byte] ^= (1 << bit);
data[byte] ^= (1 << bit);
- return 1; /* Corrected the error */
+ return 1;
/* Corrected the error */
}
}
- if ((yaffs_count_bits(d0) +
- yaffs_count_bits(d1) +
- yaffs_count_bits(d2)) == 1) {
+ if ((hweight8(d0) + hweight8(d1) + hweight8(d2)) == 1) {
/* Reccoverable error in ecc */
read_ecc[0] = test_ecc[0];
read_ecc[1] = test_ecc[1];
read_ecc[2] = test_ecc[2];
/* Reccoverable error in ecc */
read_ecc[0] = test_ecc[0];
read_ecc[1] = test_ecc[1];
read_ecc[2] = test_ecc[2];
- return 1; /* Corrected the error */
+ return 1;
/* Corrected the error */
}
/* Unrecoverable error */
}
/* Unrecoverable error */
@@
-241,12
+215,11
@@
int yaffs_ecc_correct(unsigned char *data, unsigned char *read_ecc,
}
}
-
/*
* ECCxxxOther does ECC calcs on arbitrary n bytes of data
*/
/*
* ECCxxxOther does ECC calcs on arbitrary n bytes of data
*/
-void yaffs_ecc_calc_other(const unsigned char *data, unsigned n
B
ytes,
-
yaffs_ECCOther *eccO
ther)
+void yaffs_ecc_calc_other(const unsigned char *data, unsigned n
_b
ytes,
+
struct yaffs_ecc_other *ecc_o
ther)
{
unsigned int i;
{
unsigned int i;
@@
-255,11
+228,11
@@
void yaffs_ecc_calc_other(const unsigned char *data, unsigned nBytes,
unsigned line_parity_prime = 0;
unsigned char b;
unsigned line_parity_prime = 0;
unsigned char b;
- for (i = 0; i < n
B
ytes; i++) {
+ for (i = 0; i < n
_b
ytes; i++) {
b = column_parity_table[*data++];
col_parity ^= b;
b = column_parity_table[*data++];
col_parity ^= b;
- if (b & 0x01)
{
+ if (b & 0x01) {
/* odd number of bits in the byte */
line_parity ^= i;
line_parity_prime ^= ~i;
/* odd number of bits in the byte */
line_parity ^= i;
line_parity_prime ^= ~i;
@@
-267,54
+240,56
@@
void yaffs_ecc_calc_other(const unsigned char *data, unsigned nBytes,
}
}
- ecc
Other->colP
arity = (col_parity >> 2) & 0x3f;
- ecc
Other->lineP
arity = line_parity;
- ecc
Other->lineParityP
rime = line_parity_prime;
+ ecc
_other->col_p
arity = (col_parity >> 2) & 0x3f;
+ ecc
_other->line_p
arity = line_parity;
+ ecc
_other->line_parity_p
rime = line_parity_prime;
}
}
-int yaffs_ecc_correct_other(unsigned char *data, unsigned n
B
ytes,
-
yaffs_ECCO
ther *read_ecc,
-
const yaffs_ECCO
ther *test_ecc)
+int yaffs_ecc_correct_other(unsigned char *data, unsigned n
_b
ytes,
+
struct yaffs_ecc_o
ther *read_ecc,
+
const struct yaffs_ecc_o
ther *test_ecc)
{
{
- unsigned char
cDelta;
/* column parity delta */
- unsigned
lDelta;
/* line parity delta */
- unsigned
lDeltaPrime;
/* line parity delta */
+ unsigned char
delta_col;
/* column parity delta */
+ unsigned
delta_line;
/* line parity delta */
+ unsigned
delta_line_prime;
/* line parity delta */
unsigned bit;
unsigned bit;
- cDelta = read_ecc->colParity ^ test_ecc->colParity;
- lDelta = read_ecc->lineParity ^ test_ecc->lineParity;
- lDeltaPrime = read_ecc->lineParityPrime ^ test_ecc->lineParityPrime;
+ delta_col = read_ecc->col_parity ^ test_ecc->col_parity;
+ delta_line = read_ecc->line_parity ^ test_ecc->line_parity;
+ delta_line_prime =
+ read_ecc->line_parity_prime ^ test_ecc->line_parity_prime;
- if ((
cDelta | lDelta | lDeltaP
rime) == 0)
- return 0; /* no error */
+ if ((
delta_col | delta_line | delta_line_p
rime) == 0)
+ return 0;
/* no error */
- if (
lDelta == ~lDeltaP
rime &&
- (((
cDelta ^ (cDelta
>> 1)) & 0x15) == 0x15)) {
+ if (
delta_line == ~delta_line_p
rime &&
+ (((
delta_col ^ (delta_col
>> 1)) & 0x15) == 0x15)) {
/* Single bit (recoverable) error in data */
bit = 0;
/* Single bit (recoverable) error in data */
bit = 0;
- if (
cDelta
& 0x20)
+ if (
delta_col
& 0x20)
bit |= 0x04;
bit |= 0x04;
- if (
cDelta
& 0x08)
+ if (
delta_col
& 0x08)
bit |= 0x02;
bit |= 0x02;
- if (
cDelta
& 0x02)
+ if (
delta_col
& 0x02)
bit |= 0x01;
bit |= 0x01;
- if (
lDelta >= nB
ytes)
+ if (
delta_line >= n_b
ytes)
return -1;
return -1;
- data[
lDelta
] ^= (1 << bit);
+ data[
delta_line
] ^= (1 << bit);
- return 1; /* corrected */
+ return 1;
/* corrected */
}
}
- if ((yaffs_count_bits32(lDelta) + yaffs_count_bits32(lDeltaPrime) +
- yaffs_count_bits(cDelta)) == 1) {
+ if ((hweight32(delta_line) +
+ hweight32(delta_line_prime) +
+ hweight8(delta_col)) == 1) {
/* Reccoverable error in ecc */
*read_ecc = *test_ecc;
/* Reccoverable error in ecc */
*read_ecc = *test_ecc;
- return 1; /* corrected */
+ return 1;
/* corrected */
}
/* Unrecoverable error */
}
/* Unrecoverable error */