<ruleset name="drupal_core">
<description>Default PHP CodeSniffer configuration for Drupal core.</description>
<file>.</file>
+ <file>scripts/drupal.sh</file>
+ <file>scripts/password-hash.sh</file>
+ <file>scripts/rebuild_token_calculator.sh</file>
+ <file>scripts/run-tests.sh</file>
+ <file>scripts/update-countries.sh</file>
<arg name="extensions" value="inc,install,module,php,profile,test,theme"/>
<!--Exclude third party code.-->
<!--Exclude test files that are intentionally empty, or intentionally violate coding standards.-->
<exclude-pattern>./modules/system/tests/fixtures/HtaccessTest</exclude-pattern>
+ <!-- Exclude third-party code maintained within core that does not follow our standards. -->
+ <!-- @todo This rule may be removed when https://www.drupal.org/node/1848264 is resolved. -->
+ <exclude-pattern>./core/lib/Drupal/Component/Diff/</exclude-pattern>
+
<!-- Only include specific sniffs that pass. This ensures that, if new sniffs are added, HEAD does not fail.-->
<!-- Drupal sniffs -->
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/ClassCreateInstanceSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/ClassDeclarationSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/FullyQualifiedNamespaceSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Classes/UnusedUseStatementSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/CSS/ClassDefinitionNameSpacingSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/CSS/ColourDefinitionSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/ClassCommentSniff.php">
+ <rule ref="Drupal.Classes.ClassCreateInstance"/>
+ <rule ref="Drupal.Classes.ClassDeclaration"/>
+ <rule ref="Drupal.Classes.FullyQualifiedNamespace"/>
+ <rule ref="Drupal.Classes.InterfaceName"/>
+ <rule ref="Drupal.Classes.UnusedUseStatement"/>
+ <rule ref="Drupal.Classes.UseLeadingBackslash"/>
+ <rule ref="Drupal.CSS.ClassDefinitionNameSpacing"/>
+ <rule ref="Drupal.CSS.ColourDefinition"/>
+ <rule ref="Drupal.Commenting.ClassComment">
<exclude name="Drupal.Commenting.ClassComment.Missing"/>
</rule>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/DocCommentSniff.php">
+ <rule ref="Drupal.Commenting.DataTypeNamespace"/>
+ <rule ref="Drupal.Commenting.DocComment">
<!-- Sniff for these errors: SpacingAfterTagGroup, WrongEnd, SpacingBetween,
ContentAfterOpen, SpacingBeforeShort, TagValueIndent, ShortStartSpace,
SpacingAfter -->
<exclude name="Drupal.Commenting.DocComment.TagGroupSpacing"/>
<exclude name="Drupal.Commenting.DocComment.MissingShort"/>
</rule>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/DocCommentStarSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FileCommentSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Commenting/FunctionCommentSniff.php">
+ <rule ref="Drupal.Commenting.DocCommentStar"/>
+ <rule ref="Drupal.Commenting.FileComment"/>
+ <rule ref="Drupal.Commenting.FunctionComment">
<exclude name="Drupal.Commenting.FunctionComment.IncorrectTypeHint"/>
<exclude name="Drupal.Commenting.FunctionComment.InvalidNoReturn"/>
- <exclude name="Drupal.Commenting.FunctionComment.InvalidReturnNotVoid"/>
<exclude name="Drupal.Commenting.FunctionComment.InvalidTypeHint"/>
<exclude name="Drupal.Commenting.FunctionComment.Missing"/>
- <exclude name="Drupal.Commenting.FunctionComment.MissingFile"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingParamComment"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingParamType"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingReturnComment"/>
<exclude name="Drupal.Commenting.FunctionComment.MissingReturnType"/>
<exclude name="Drupal.Commenting.FunctionComment.ParamCommentFullStop"/>
- <exclude name="Drupal.Commenting.FunctionComment.ParamCommentIndentation"/>
- <exclude name="Drupal.Commenting.FunctionComment.ParamCommentNewLine"/>
- <exclude name="Drupal.Commenting.FunctionComment.ParamCommentNotCapital"/>
<exclude name="Drupal.Commenting.FunctionComment.ParamMissingDefinition"/>
- <exclude name="Drupal.Commenting.FunctionComment.ParamNameNoMatch"/>
- <exclude name="Drupal.Commenting.FunctionComment.ParamTypeSpaces"/>
- <exclude name="Drupal.Commenting.FunctionComment.ReturnCommentIndentation"/>
- <exclude name="Drupal.Commenting.FunctionComment.ReturnTypeSpaces"/>
<exclude name="Drupal.Commenting.FunctionComment.TypeHintMissing"/>
</rule>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/ControlStructures/ElseIfSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/ControlStructures/ControlSignatureSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Files/EndFileNewlineSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Files/TxtFileLineLengthSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Formatting/SpaceInlineIfSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Formatting/SpaceUnaryOperatorSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Functions/DiscouragedFunctionsSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Functions/FunctionDeclarationSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/AutoAddedKeysSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/ClassFilesSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/DuplicateEntrySniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/InfoFiles/RequiredSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Scope/MethodScopeSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/EmptyInstallSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/FunctionTSniff.php">
- <exclude name="Drupal.Semantics.FunctionT.BackslashSingleQuote"/>
+ <rule ref="Drupal.Commenting.VariableComment">
+ <!-- Sniff for: DuplicateVar, EmptyVar, InlineVariableName -->
+ <exclude name="Drupal.Commenting.VariableComment.IncorrectVarType"/>
+ <exclude name="Drupal.Commenting.VariableComment.MissingVar"/>
+ <exclude name="Drupal.Commenting.VariableComment.VarOrder"/>
+ <exclude name="Drupal.Commenting.VariableComment.WrongStyle"/>
+ </rule>
+ <rule ref="Drupal.Commenting.InlineComment">
+ <!-- Sniff for: NoSpaceBefore, WrongStyle -->
+ <exclude name="Drupal.Commenting.InlineComment.DocBlock"/>
+ <exclude name="Drupal.Commenting.InlineComment.InvalidEndChar"/>
+ <exclude name="Drupal.Commenting.InlineComment.NotCapital"/>
+ <exclude name="Drupal.Commenting.InlineComment.SpacingAfter"/>
+ <exclude name="Drupal.Commenting.InlineComment.SpacingBefore"/>
+ </rule>
+ <rule ref="Drupal.Commenting.PostStatementComment"/>
+ <rule ref="Drupal.ControlStructures.ElseIf"/>
+ <rule ref="Drupal.ControlStructures.ControlSignature"/>
+ <rule ref="Drupal.ControlStructures.InlineControlStructure"/>
+ <rule ref="Drupal.Files.EndFileNewline"/>
+ <rule ref="Drupal.Files.FileEncoding"/>
+ <rule ref="Drupal.Files.TxtFileLineLength"/>
+ <rule ref="Drupal.Formatting.MultiLineAssignment"/>
+ <rule ref="Drupal.Formatting.SpaceInlineIf"/>
+ <rule ref="Drupal.Formatting.SpaceUnaryOperator"/>
+ <rule ref="Drupal.Functions.DiscouragedFunctions"/>
+ <rule ref="Drupal.Functions.FunctionDeclaration"/>
+ <rule ref="Drupal.InfoFiles.AutoAddedKeys"/>
+ <rule ref="Drupal.InfoFiles.ClassFiles"/>
+ <rule ref="Drupal.InfoFiles.DuplicateEntry"/>
+ <rule ref="Drupal.InfoFiles.Required"/>
+ <rule ref="Drupal.Methods.MethodDeclaration">
+ <!-- Silence method name underscore warning which is covered already in
+ Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps. -->
+ <exclude name="Drupal.Methods.MethodDeclaration.Underscore"/>
+ </rule>
+ <rule ref="Drupal.NamingConventions.ValidVariableName">
+ <!-- Sniff for: LowerStart -->
+ <exclude name="Drupal.NamingConventions.ValidVariableName.LowerCamelName"/>
+ </rule>
+ <rule ref="Drupal.Scope.MethodScope"/>
+ <rule ref="Drupal.Semantics.EmptyInstall"/>
+ <rule ref="Drupal.Semantics.FunctionAlias"/>
+ <rule ref="Drupal.Semantics.FunctionT">
<exclude name="Drupal.Semantics.FunctionT.NotLiteralString"/>
<exclude name="Drupal.Semantics.FunctionT.ConcatString"/>
</rule>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/FunctionWatchdogSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/InstallHooksSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/LStringTranslatableSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/PregSecuritySniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/TInHookMenuSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/Semantics/TInHookSchemaSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/CommaSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ObjectOperatorIndentSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ObjectOperatorSpacingSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/OpenTagNewlineSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/OperatorSpacingSniff.php"/>
- <rule ref="../vendor/drupal/coder/coder_sniffer/Drupal/Sniffs/WhiteSpace/ScopeIndentSniff.php"/>
+ <rule ref="Drupal.Semantics.FunctionWatchdog"/>
+ <rule ref="Drupal.Semantics.InstallHooks"/>
+ <rule ref="Drupal.Semantics.LStringTranslatable"/>
+ <rule ref="Drupal.Semantics.PregSecurity"/>
+ <rule ref="Drupal.Semantics.TInHookMenu"/>
+ <rule ref="Drupal.Semantics.TInHookSchema"/>
+ <rule ref="Drupal.WhiteSpace.CloseBracketSpacing"/>
+ <rule ref="Drupal.WhiteSpace.Comma"/>
+ <rule ref="Drupal.WhiteSpace.EmptyLines"/>
+ <rule ref="Drupal.WhiteSpace.Namespace"/>
+ <rule ref="Drupal.WhiteSpace.ObjectOperatorIndent"/>
+ <rule ref="Drupal.WhiteSpace.ObjectOperatorSpacing"/>
+ <rule ref="Drupal.WhiteSpace.OpenBracketSpacing"/>
+ <rule ref="Drupal.WhiteSpace.OpenTagNewline"/>
+ <rule ref="Drupal.WhiteSpace.OperatorSpacing"/>
+ <rule ref="Drupal.WhiteSpace.ScopeClosingBrace"/>
+ <rule ref="Drupal.WhiteSpace.ScopeIndent"/>
<!-- Drupal Practice sniffs -->
- <rule ref="../vendor/drupal/coder/coder_sniffer/DrupalPractice/Sniffs/Commenting/ExpectedExceptionSniff.php"/>
+ <rule ref="DrupalPractice.Commenting.ExpectedException"/>
<!-- Generic sniffs -->
+ <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
+ <rule ref="Generic.Files.ByteOrderMark"/>
<rule ref="Generic.Files.LineEndings"/>
+ <rule ref="Generic.Formatting.SpaceAfterCast"/>
<rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
+ <rule ref="Generic.Functions.OpeningFunctionBraceKernighanRitchie">
+ <properties>
+ <property name="checkClosures" value="true"/>
+ </properties>
+ </rule>
+ <rule ref="Generic.NamingConventions.ConstructorName"/>
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
<rule ref="Generic.PHP.DeprecatedFunctions"/>
<rule ref="Generic.PHP.DisallowShortOpenTag"/>
+ <rule ref="Generic.PHP.LowerCaseKeyword"/>
<rule ref="Generic.PHP.UpperCaseConstant"/>
<rule ref="Generic.WhiteSpace.DisallowTabIndent"/>
- <rule ref="Generic.Arrays.DisallowLongArraySyntax" />
+
+ <!-- MySource sniffs -->
+ <rule ref="MySource.Debug.DebugCode"/>
+
+ <!-- PEAR sniffs -->
+ <rule ref="PEAR.Files.IncludingFile"/>
+ <!-- Disable some error messages that we do not want. -->
+ <rule ref="PEAR.Files.IncludingFile.UseIncludeOnce">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Files.IncludingFile.UseInclude">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Files.IncludingFile.UseRequireOnce">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Files.IncludingFile.UseRequire">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Functions.ValidDefaultValue"/>
+
+ <!-- PEAR sniffs -->
+ <rule ref="PEAR.Functions.FunctionCallSignature"/>
+ <!-- The sniffs inside PEAR.Functions.FunctionCallSignature silenced below are
+ also silenced in Drupal CS' ruleset.xml. The code below is a 1-on-1 copy
+ from that file. -->
+ <!-- Disable some error messages that we already cover. -->
+ <rule ref="PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket">
+ <severity>0</severity>
+ </rule>
+ <!-- Disable some error messages that we do not want. -->
+ <rule ref="PEAR.Functions.FunctionCallSignature.Indent">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Functions.FunctionCallSignature.CloseBracketLine">
+ <severity>0</severity>
+ </rule>
+ <rule ref="PEAR.Functions.FunctionCallSignature.EmptyLine">
+ <severity>0</severity>
+ </rule>
<!-- PSR-2 sniffs -->
<rule ref="PSR2.Classes.PropertyDeclaration">
<exclude name="PSR2.Classes.PropertyDeclaration.Underscore"/>
</rule>
+ <rule ref="PSR2.Namespaces.NamespaceDeclaration"/>
+ <rule ref="PSR2.Namespaces.UseDeclaration">
+ <exclude name="PSR2.Namespaces.UseDeclaration.UseAfterNamespace"/>
+ </rule>
<!-- Squiz sniffs -->
+ <rule ref="Squiz.Arrays.ArrayBracketSpacing"/>
+ <rule ref="Squiz.Arrays.ArrayDeclaration">
+ <exclude name="Squiz.Arrays.ArrayDeclaration.NoKeySpecified"/>
+ <exclude name="Squiz.Arrays.ArrayDeclaration.KeySpecified"/>
+ </rule>
+ <!-- Disable some error messages that we do not want. -->
+ <rule ref="Squiz.Arrays.ArrayDeclaration.CloseBraceNotAligned">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.DoubleArrowNotAligned">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.FirstValueNoNewline">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.KeyNotAligned">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.MultiLineNotAllowed">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.NoComma">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.NoCommaAfterLast">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.NotLowerCase">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.SingleLineNotAllowed">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.ValueNotAligned">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Arrays.ArrayDeclaration.ValueNoNewline">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.ControlStructures.ForEachLoopDeclaration"/>
+ <!-- Disable some error messages that we already cover. -->
+ <rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceAfterOpen">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceBeforeClose">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.ControlStructures.ForLoopDeclaration"/>
+ <!-- Disable some error messages that we already cover. -->
+ <rule ref="Squiz.ControlStructures.ForLoopDeclaration.SpacingAfterOpen">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.ControlStructures.ForLoopDeclaration.SpacingBeforeClose">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Functions.MultiLineFunctionDeclaration"/>
+ <rule ref="Squiz.Functions.MultiLineFunctionDeclaration.BraceOnSameLine">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Functions.MultiLineFunctionDeclaration.ContentAfterBrace">
+ <severity>0</severity>
+ </rule>
+ <!-- Standard yet to be finalized on this (https://www.drupal.org/node/1539712). -->
+ <rule ref="Squiz.Functions.MultiLineFunctionDeclaration.FirstParamSpacing">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Functions.MultiLineFunctionDeclaration.Indent">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Functions.MultiLineFunctionDeclaration.CloseBracketLine">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
+ <properties>
+ <property name="equalsSpacing" value="1"/>
+ </properties>
+ </rule>
+ <rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing.NoSpaceBeforeArg">
+ <severity>0</severity>
+ </rule>
+ <rule ref="Squiz.PHP.LowercasePHPFunctions"/>
<rule ref="Squiz.Strings.ConcatenationSpacing">
<properties>
<property name="spacing" value="1"/>
<property name="ignoreNewlines" value="true"/>
</properties>
- </rule>
+ </rule>
+ <rule ref="Squiz.WhiteSpace.LanguageConstructSpacing" />
+ <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
+ <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/>
+
+ <!-- Zend sniffs -->
+ <rule ref="Zend.Files.ClosingTag"/>
</ruleset>
projects / yaffs-website / blobdiff